mirrors/retrospring
1
0
Fork 0
mirror of https://github.com/Retrospring/retrospring.git synced 2025-01-19 06:06:05 +01:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1203 from Retrospring/fix/notification-bugs

Browse source 
Notification dropdown fixes
This commit is contained in:
Karina Kwiatek 2023-05-08 19:16:33 +02:00 • committed by GitHub
commit 333af458db
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/controllers/notifications_controller.rb
View file

@ -27,6 +27,7 @@ class NotificationsController < ApplicationController
def read def read
current_user.notifications.where(new: true).update_all(new: false) # rubocop:disable Rails/SkipsModelValidations current_user.notifications.where(new: true).update_all(new: false) # rubocop:disable Rails/SkipsModelValidations
current_user.touch(:notifications_updated_at)
respond_to do |format| respond_to do |format|
format.turbo_stream do format.turbo_stream do

2
app/views/notifications/type/_nilclass.html.haml Normal file
View file

@ -0,0 +1,2 @@
-# This is a stub to prevent errors on broken notifications on content being asynchronously destroyed.
- logger.error "Notification ##{notification.id} has a target which doesn't exist. (Target: #{notification.target_type}##{notification.target_id})"