From 6a7f63e671e95ef1db6a2798bd4301e6455d8219 Mon Sep 17 00:00:00 2001 From: Andreas Nedbal Date: Fri, 6 Jan 2023 15:50:35 +0100 Subject: [PATCH] Remove Webpacker references in test suite --- .github/workflows/retrospring.yml | 1 - spec/rails_helper.rb | 14 -------------- 2 files changed, 15 deletions(-) diff --git a/.github/workflows/retrospring.yml b/.github/workflows/retrospring.yml index 56223c0a..35938753 100644 --- a/.github/workflows/retrospring.yml +++ b/.github/workflows/retrospring.yml @@ -74,7 +74,6 @@ jobs: env: POSTGRES_PORT: ${{ job.services.postgres.ports[5432] }} REDIS_URL: "redis://localhost:${{ job.services.redis.ports[6379] }}" - DISABLE_WEBPACK_IN_TESTS: 1 - uses: codecov/codecov-action@v3 with: token: ${{ secrets.CODECOV_TOKEN }} diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index c6b03bd1..90ade2fe 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -32,20 +32,6 @@ require "rspec-sidekiq" ActiveRecord::Migration.maintain_test_schema! RSpec.configure do |config| - config.before :suite do - # Run webpack compilation before suite, so assets exists in public/packs - # It would be better to run the webpack compilation only if at least one :js spec - # should be executed, but `when_first_matching_example_defined` - # does not work with `config.infer_spec_type_from_file_location!` - # see https://github.com/rspec/rspec-core/issues/2366 - - unless ENV.key?("DISABLE_WEBPACK_IN_TESTS") - start = Time.now # rubocop:disable all - `bin/webpack` - puts "processing time of webpack: \033[32;1m#{(Time.now - start).round(3).to_s.ljust(5, '0')}s\033[0m" # rubocop:disable all - end - end - # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures config.fixture_path = "#{::Rails.root}/spec/fixtures"