From 754335143b10a185246a7a721ac69e4256534457 Mon Sep 17 00:00:00 2001 From: Andreas Nedbal Date: Sun, 9 Mar 2025 19:29:14 +0100 Subject: [PATCH] Use ActiveRecord.find instead of dynamic methods --- lib/use_case/report/create.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/use_case/report/create.rb b/lib/use_case/report/create.rb index 903f164b..c00cf983 100644 --- a/lib/use_case/report/create.rb +++ b/lib/use_case/report/create.rb @@ -50,20 +50,18 @@ module UseCase ::Report.create(type: "Reports::#{object.class}", target_id: object.id, user_id: reporter.id, target_user_id: target_user&.id, reason: reason) end - # rubocop:disable Rails/DynamicFindBy def object @object ||= case object_type.strip.capitalize when "User" ::User.find_by_screen_name!(object_id) when "Question" - ::Question.find_by_id(object_id) + ::Question.find(object_id) when "Answer" - ::Answer.find_by_id(object_id) + ::Answer.find(object_id) when "Comment" - ::Comment.find_by_id(object_id) + ::Comment.find(object_id) end end - # rubocop:enable Rails/DynamicFindBy def reporter @reporter ||= ::User.find(reporter_id)