mirrors/retrospring
1
0
Fork 0
mirror of https://github.com/Retrospring/retrospring.git synced 2024-11-20 18:29:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use screen_name instead of target_user param in Ajax::RelationshipController

Browse source
This commit is contained in:
Karina Kwiatek 2022-01-19 19:24:54 +01:00 • committed by Karina Kwiatek
parent b4e0699e82
commit 8d59ef9398
2 changed files with 20 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
app/controllers/ajax/relationship_controller.rb
View file

@ -8,15 +8,15 @@ class Ajax::RelationshipController < AjaxController
before_action :authenticate_user!
def create
params.require :target_user
params.require :screen_name
UseCase::Relationship::Create.call(
current_user: current_user.screen_name,
target_user: params[:target_user],
target_user: params[:screen_name],
type: params[:type]
)
@response[:success] = true
@response[:message] = t("messages.friend.create.success")
@response[:message] = t("messages.friend.create.okay")
rescue Errors::Base => e
@response[:message] = t(e.locale_tag)
ensure
@ -26,13 +26,13 @@ class Ajax::RelationshipController < AjaxController
def destroy
UseCase::Relationship::Destroy.call(
current_user: current_user.screen_name,
target_user: params[:target_user],
target_user: params[:screen_name],
type: params[:type]
)
@response[:success] = true
@response[:message] = t("messages.friend.create.success")
@response[:message] = t("messages.friend.destroy.okay")
rescue Errors::Base => e
@response[:message] = t(e.locale_tag)
@response[:message] = t("messages.friend.destroy.fail")
ensure
return_response
end

28
spec/controllers/ajax/relationship_controller_spec.rb
View file

@ -17,31 +17,31 @@ describe Ajax::RelationshipController, type: :controller do
shared_examples_for "valid relationship type" do
it_behaves_like "params is empty"
context "target_user does not exist" do
let(:target_user) { "peter-witzig" }
context "screen_name does not exist" do
let(:screen_name) { "peter-witzig" }
include_examples "ajax does not succeed", "not found"
end
context "target_user is current user" do
let(:target_user) { user.screen_name }
context "screen_name is current user" do
let(:screen_name) { user.screen_name }
include_examples "ajax does not succeed", "yourself"
end
context "target_user is different from current_user" do
let(:target_user) { user2.screen_name }
context "screen_name is different from current_user" do
let(:screen_name) { user2.screen_name }
it "creates the relationship" do
expect { subject }.to change { Relationship.count }.by(1)
expect(Relationship.last.target.screen_name).to eq(target_user)
expect(Relationship.last.target.screen_name).to eq(screen_name)
end
end
end
let(:type) { "Sauerkraut" }
let(:target_user) { user2.screen_name }
let(:params) { { type: type, target_user: target_user } }
let(:screen_name) { user2.screen_name }
let(:params) { { type: type, screen_name: screen_name } }
subject { post(:create, params: params) }
@ -67,7 +67,7 @@ describe Ajax::RelationshipController, type: :controller do
describe "#destroy" do
shared_examples_for "valid relationship type" do
let(:target_user) { user2.screen_name }
let(:screen_name) { user2.screen_name }
context "relationship exists" do
before do
@ -85,16 +85,16 @@ describe Ajax::RelationshipController, type: :controller do
end
end
context "target_user does not exist" do
let(:target_user) { "peter-witzig" }
context "screen_name does not exist" do
let(:screen_name) { "peter-witzig" }
include_examples "ajax does not succeed", "not found"
end
end
let(:type) { "Sauerkraut" }
let(:target_user) { user2.screen_name }
let(:params) { { type: type, target_user: target_user } }
let(:screen_name) { user2.screen_name }
let(:params) { { type: type, screen_name: screen_name } }
subject { delete(:destroy, params: params) }