mirrors/retrospring
1
0
Fork 1
mirror of https://github.com/Retrospring/retrospring.git synced 2025-03-31 05:02:14 +02:00
Code Issues Projects Releases Packages Wiki Activity

Refactor Ajax::ListController

Browse source 
* remove inline authentication checks and use before_action instead
* remove begin/rescue catches as those are handled by the base controller and validations now
This commit is contained in:
Andreas Nedbal 2022-07-09 19:05:11 +02:00 • committed by Karina Kwiatek
parent a3f80380dd
commit a5b6ef07d3
1 changed files with 12 additions and 68 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

80
app/controllers/ajax/list_controller.rb
View file

@ -1,42 +1,13 @@
class Ajax::ListController < AjaxController class Ajax::ListController < AjaxController
before_action :authenticate_user!
def create def create
params.require :name
@response[:status] = :err @response[:status] = :err
unless user_signed_in? target_user = User.find_by_screen_name!(params[:user])
@response[:status] = :noauth list = List.create! user: current_user, display_name: params[:name]
@response[:message] = t(".noauth")
return
end
begin
params.require :name
rescue ActionController::ParameterMissing => e
Sentry.capture_exception(e)
@response[:status] = :toolong
@response[:message] = t(".noname")
return
end
params.require :user
begin
target_user = User.find_by_screen_name!(params[:user])
list = List.create! user: current_user, display_name: params[:name]
rescue ActiveRecord::RecordInvalid => e
Sentry.capture_exception(e)
@response[:status] = :toolong
@response[:message] = t(".toolong")
return
rescue ActiveRecord::RecordNotFound => e
Sentry.capture_exception(e)
@response[:status] = :notfound
@response[:message] = t(".notfound")
return
rescue ActiveRecord::RecordNotUnique => e
Sentry.capture_exception(e)
@response[:status] = :exists
@response[:message] = t(".exists")
return
end
@response[:status] = :okay @response[:status] = :okay
@response[:success] = true @response[:success] = true
@ -45,24 +16,11 @@ class Ajax::ListController < AjaxController
end end
def destroy def destroy
@response[:status] = :err
unless user_signed_in?
@response[:status] = :noauth
@response[:message] = t(".noauth")
return
end
params.require :list params.require :list
begin @response[:status] = :err
List.where(user: current_user, name: params[:list]).first.destroy!
rescue ActiveRecord::RecordNotFound => e List.where(user: current_user, name: params[:list]).first.destroy!
Sentry.capture_exception(e)
@response[:status] = :notfound
@response[:message] = t(".notfound")
return
end
@response[:status] = :okay @response[:status] = :okay
@response[:success] = true @response[:success] = true
@ -70,30 +28,16 @@ class Ajax::ListController < AjaxController
end end
def membership def membership
@response[:status] = :err
unless user_signed_in?
@response[:status] = :noauth
@response[:message] = t(".noauth")
return
end
params.require :user params.require :user
params.require :list params.require :list
params.require :add params.require :add
@response[:status] = :err
add = params[:add] == 'true' add = params[:add] == 'true'
begin
list = current_user.lists.find_by_name!(params[:list])
rescue ActiveRecord::RecordNotFound => e
Sentry.capture_exception(e)
@response[:status] = :notfound
@response[:message] = t(".notfound")
return
end
target_user = User.find_by_screen_name!(params[:user]) target_user = User.find_by_screen_name!(params[:user])
list = current_user.lists.find_by_name!(params[:list])
raise Errors::ListingSelfBlockedOther if current_user.blocking?(target_user) raise Errors::ListingSelfBlockedOther if current_user.blocking?(target_user)
raise Errors::ListingOtherBlockedSelf if target_user.blocking?(current_user) raise Errors::ListingOtherBlockedSelf if target_user.blocking?(current_user)