From 0c97ae60d4265bc153e9f6b785df0a354388ab5c Mon Sep 17 00:00:00 2001 From: nilsding Date: Wed, 14 Jan 2015 07:50:27 +0100 Subject: [PATCH] finally got rid of that .each --- app/models/user.rb | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/models/user.rb b/app/models/user.rb index 46adacff..04327e71 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -104,8 +104,7 @@ class User < ActiveRecord::Base # has the user answered +question+ yet? # @param question [Question] def answered?(question) - question.answers.each { |a| return true if a.user_id == self.id } - false + question.answers.pluck(:user_id).include? self.id end # smiles an answer @@ -121,9 +120,7 @@ class User < ActiveRecord::Base end def smiled?(answer) - # TODO: you know what to do here, nilsding - answer.smiles.each { |s| return true if s.user_id == self.id } - false + answer.smiles.pluck(:user_id).include? self.id end def display_website