From 93910a1655f0f536d8927415935ab316bcad376f Mon Sep 17 00:00:00 2001
From: rr- <rr-@sakuya.pl>
Date: Mon, 8 Apr 2019 22:06:42 +0200
Subject: [PATCH] client/tags: fix post search links

---
 client/html/post_readonly_sidebar.tpl               |  2 +-
 client/html/tag_delete.tpl                          |  2 +-
 client/html/tag_summary.tpl                         |  2 +-
 client/js/controllers/tag_controller.js             |  1 +
 client/js/controls/post_readonly_sidebar_control.js |  2 ++
 client/js/controls/tag_input_control.js             |  3 ++-
 client/js/util/uri.js                               | 11 ++++++++---
 7 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/client/html/post_readonly_sidebar.tpl b/client/html/post_readonly_sidebar.tpl
index cf786c6..54d7241 100644
--- a/client/html/post_readonly_sidebar.tpl
+++ b/client/html/post_readonly_sidebar.tpl
@@ -89,7 +89,7 @@
                             --></a><!--
                         --><% } %><!--
                         --><% if (ctx.canListPosts) { %><!--
-                            --><a href='<%- ctx.formatClientLink('posts', {query: tag.names[0]}) %>' class='<%= ctx.makeCssName(tag.category, 'tag') %>'><!--
+                            --><a href='<%- ctx.formatClientLink('posts', {query: ctx.escapeColons(tag.names[0])}) %>' class='<%= ctx.makeCssName(tag.category, 'tag') %>'><!--
                         --><% } %><!--
                             --><%- tag.names[0] %>&#32;<!--
                         --><% if (ctx.canListPosts) { %><!--
diff --git a/client/html/tag_delete.tpl b/client/html/tag_delete.tpl
index e7be8cf..2ea8cba 100644
--- a/client/html/tag_delete.tpl
+++ b/client/html/tag_delete.tpl
@@ -1,6 +1,6 @@
 <div class='tag-delete'>
     <form>
-        <p>This tag has <a href='<%- ctx.formatClientLink('posts', {query: ctx.tag.names[0]}) %>'><%- ctx.tag.postCount %> usage(s)</a>.</p>
+        <p>This tag has <a href='<%- ctx.formatClientLink('posts', {query: ctx.escapeColons(ctx.tag.names[0])}) %>'><%- ctx.tag.postCount %> usage(s)</a>.</p>
 
         <ul class='input'>
             <li>
diff --git a/client/html/tag_summary.tpl b/client/html/tag_summary.tpl
index ad00084..9929a44 100644
--- a/client/html/tag_summary.tpl
+++ b/client/html/tag_summary.tpl
@@ -36,6 +36,6 @@
     <section class='description'>
         <hr/>
         <%= ctx.makeMarkdown(ctx.tag.description || 'This tag has no description yet.') %>
-        <p>This tag has <a href='<%- ctx.formatClientLink('posts', {query: ctx.tag.names[0]}) %>'><%- ctx.tag.postCount %> usage(s)</a>.</p>
+        <p>This tag has <a href='<%- ctx.formatClientLink('posts', {query: ctx.escapeColons(ctx.tag.names[0])}) %>'><%- ctx.tag.postCount %> usage(s)</a>.</p>
     </section>
 </div>
diff --git a/client/js/controllers/tag_controller.js b/client/js/controllers/tag_controller.js
index e590840..d64ab22 100644
--- a/client/js/controllers/tag_controller.js
+++ b/client/js/controllers/tag_controller.js
@@ -47,6 +47,7 @@ class TagController {
                 canMerge: api.hasPrivilege('tags:merge'),
                 canDelete: api.hasPrivilege('tags:delete'),
                 categories: categories,
+                escapeColons: uri.escapeColons,
             });
 
             this._view.addEventListener('change', e => this._evtChange(e));
diff --git a/client/js/controls/post_readonly_sidebar_control.js b/client/js/controls/post_readonly_sidebar_control.js
index 129f48d..65c922d 100644
--- a/client/js/controls/post_readonly_sidebar_control.js
+++ b/client/js/controls/post_readonly_sidebar_control.js
@@ -3,6 +3,7 @@
 const api = require('../api.js');
 const events = require('../events.js');
 const views = require('../util/views.js');
+const uri = require('../util/uri.js');
 
 const template = views.getTemplate('post-readonly-sidebar');
 const scoreTemplate = views.getTemplate('score');
@@ -24,6 +25,7 @@ class PostReadonlySidebarControl extends events.EventTarget {
             canListPosts: api.hasPrivilege('posts:list'),
             canEditPosts: api.hasPrivilege('posts:edit'),
             canViewTags: api.hasPrivilege('tags:view'),
+            escapeColons: uri.escapeColons,
         }));
 
         this._installFav();
diff --git a/client/js/controls/tag_input_control.js b/client/js/controls/tag_input_control.js
index 1399437..1ad0957 100644
--- a/client/js/controls/tag_input_control.js
+++ b/client/js/controls/tag_input_control.js
@@ -270,7 +270,8 @@ class TagInputControl extends events.EventTarget {
             searchLinkNode.classList.add(className);
         }
         searchLinkNode.setAttribute(
-            'href', uri.formatClientLink('posts', {query: tag.names[0]}));
+            'href', uri.formatClientLink(
+                'posts', {query: uri.escapeColons(tag.names[0])}));
         searchLinkNode.textContent = tag.names[0] + ' ';
         searchLinkNode.addEventListener('click', e => {
             e.preventDefault();
diff --git a/client/js/util/uri.js b/client/js/util/uri.js
index d1075ce..4704605 100644
--- a/client/js/util/uri.js
+++ b/client/js/util/uri.js
@@ -68,21 +68,26 @@ function extractRootDomain(url) {
     let splitArr = domain.split('.');
     let arrLen = splitArr.length;
 
-    //if there is a subdomain 
+    // if there is a subdomain
     if (arrLen > 2) {
         domain = splitArr[arrLen - 2] + '.' + splitArr[arrLen - 1];
-        //check to see if it's using a Country Code Top Level Domain (ccTLD) (i.e. ".me.uk")
+        // check to see if it's using a Country Code Top Level Domain (ccTLD) (i.e. ".me.uk")
         if (splitArr[arrLen - 2].length == 2 && splitArr[arrLen - 1].length == 2) {
-            //this is using a ccTLD
+            // this is using a ccTLD
             domain = splitArr[arrLen - 3] + '.' + domain;
         }
     }
     return domain;
 }
 
+function escapeColons(text) {
+    return text.replace(new RegExp(':', 'g'), '\\:');
+}
+
 module.exports = {
     formatClientLink:  formatClientLink,
     formatApiLink:     formatApiLink,
+    escapeColons:      escapeColons,
     escapeParam:       escapeParam,
     unescapeParam:     unescapeParam,
     extractHostname:   extractHostname,